Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return HTNOWHERE in resize hit test to allow draggable regions to kick in when required #30925

Merged
merged 1 commit into from Oct 5, 2021
Merged

fix: return HTNOWHERE in resize hit test to allow draggable regions to kick in when required #30925

merged 1 commit into from Oct 5, 2021

Conversation

MarshallOfSound
Copy link
Member

Theoretical fix, not tested at all

Notes: Fixed issue where non-resizable frameless windows aren't draggable

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 13, 2021
@MarshallOfSound MarshallOfSound mentioned this pull request Sep 13, 2021
Closed
3 tasks
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/14-x-y labels Sep 13, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 14, 2021
@zcbenz zcbenz added the wip ⚒ label Sep 21, 2021
@codebytere codebytere mentioned this pull request Sep 29, 2021
Closed
3 tasks
@erickzhao
Copy link
Member

Can confirm that this works for me with the following gist: https://gist.github.com/erickzhao/124e29cdeeaf61b50001c43af0619d43

@MarshallOfSound MarshallOfSound marked this pull request as ready for review October 5, 2021 19:46
VerteDinde
VerteDinde approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MarshallOfSound MarshallOfSound merged commit 3459911 into main Oct 5, 2021
@MarshallOfSound MarshallOfSound deleted the fix-resize-frameless branch October 5, 2021 19:48
@release-clerk
Copy link

release-clerk bot commented Oct 5, 2021

Release Notes Persisted

Fixed issue where non-resizable frameless windows aren't draggable

This was referenced Oct 5, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 5, 2021

I have automatically backported this PR to "14-x-y", please check out #31298

@trop
Copy link
Contributor

trop bot commented Oct 5, 2021

I have automatically backported this PR to "15-x-y", please check out #31299

@trop trop bot added the in-flight/15-x-y label Oct 5, 2021
@trop
Copy link
Contributor

trop bot commented Oct 5, 2021

I have automatically backported this PR to "16-x-y", please check out #31300

@Draginfable
Copy link

@MarshallOfSound @VerteDinde Can you please also backport this fix for v13? Thank you

@erickzhao
Copy link
Member

Did the bug land in a patch of v13 as well? The first version originally reported was v14.0.0.

@Draginfable
Copy link

@erickzhao Yes, it also affects versions over 13.4.0 as described here.

@VerteDinde
Copy link
Member

/trop run backport-to 13-x-y

@trop
Copy link
Contributor

trop bot commented Oct 13, 2021

The backport process for this PR has been manually initiated - sending your PR to 13-x-y!

@trop trop bot mentioned this pull request Oct 13, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Oct 13, 2021

I have automatically backported this PR to "13-x-y", please check out #31414

@Draginfable
Copy link

Draginfable commented Oct 20, 2021 •
edited

Hello @VerteDinde, thank you for backporting this fix. Is there a plan to release a new v13 in the following days?

EDIT: v13.6.0 has been released and it resolves the issue. Thank you everyone!

t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
637eded 
…o kick in when required (electron#30925)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
07415f8 
…o kick in when required (electron#30925)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
5adc8a9 
…o kick in when required (electron#30925)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
5f008e3 
…o kick in when required (electron#30925)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
5425f68 
…o kick in when required (electron#30925)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@MarshallOfSound @t57ser
fix: return HTNOWHERE in resize hit test to allow draggable regions t…
4e4a353 
…o kick in when required (electron#30925)
@commit-lint commit-lint bot mentioned this pull request Jan 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MarshallOfSound @erickzhao @Draginfable @VerteDinde @jkleinsc @zcbenz