feat: enable windows control overlay on Windows #30887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
trop
bot
added
13-x-y
backport
* feat: enable windows control overlay on macOS * address review feedback * chore: address review feedback * Address review feedback * update doc per review * only enable WCO when titleBarStyle is overlay * Revert "only enable WCO when titleBarStyle is overlay" This reverts commit 1b58b5b. * Add new titleBarOverlay property to manage feature * spelling fix * Update docs/api/frameless-window.md Co-authored-by: Samuel Attard <sam@electronjs.org> * Update shell/browser/api/electron_api_browser_window.cc Co-authored-by: Samuel Attard <sam@electronjs.org> * update per review feedback Co-authored-by: Samuel Attard <sam@electronjs.org> (cherry picked from commit 1f8a46c)
cherry-picked from 41646d1 Co-Authored-By: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com> Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
mlaurencin
force-pushed
the
window-controls-overlay-add-13
branch
from
2ae841b
to
d305fce
Compare
zcbenz
approved these changes
Sep 21, 2021
zcbenz
requested changes
Sep 21, 2021
zcbenz
approved these changes
Sep 23, 2021
|
This PR requires review from @electron/wg-upgrades. |
deepak1556
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
@mlaurencin are the chromium patches direct backports or did you have to make any modifications ?
The chromium patches were just directly backported with no modifications. |
|
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29600.
See that PR for details.
Notes: Added support for Windows Control Overlay on Windows.