Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isMainFrame argument to 'certificate-error' event #30879

Merged
merged 1 commit into from Sep 21, 2021
Merged

feat: add isMainFrame argument to 'certificate-error' event #30879

merged 1 commit into from Sep 21, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 8, 2021

Description of Change

Fixes #30662

Checklist

Release Notes

Notes: Added isMainFrame argument to 'certificate-error' event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2021
@miniak miniak self-assigned this Sep 8, 2021
@miniak miniak added semver/minor backwards-compatible functionality target/15-x-y labels Sep 8, 2021
codebytere
codebytere approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

samuelmaddock
samuelmaddock approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon
Copy link
Member

nornagon commented Sep 8, 2021

urgh, generally for this sort of thing I would rather that we expose the WebFrameMain specifically that is the source of the request, but in this case it looks like the underlying API doesn't provide that information, which is disappointing.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2021
zcbenz
zcbenz approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@zcbenz zcbenz merged commit 92bff00 into main Sep 21, 2021
@zcbenz zcbenz deleted the miniak/certificate-error-is-main-frame branch September 21, 2021 06:49
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2021

Release Notes Persisted

Added isMainFrame argument to 'certificate-error' event.

@trop trop bot mentioned this pull request Sep 21, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 21, 2021

I have automatically backported this PR to "15-x-y", please check out #31038

@commit-lint commit-lint bot mentioned this pull request Dec 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
api-review/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Expose isMainFrame on the "certificate-error" event
6 participants
@miniak @nornagon @zcbenz @samuelmaddock @codebytere @MarshallOfSound