Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undocked devtools not resizable on Windows #30847

Merged
merged 1 commit into from Sep 6, 2021
Merged

fix: undocked devtools not resizable on Windows #30847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions shell/browser/ui/views/inspectable_web_contents_view_views.cc
View file
Open in desktop
Expand Up @@ -43,8 +43,6 @@ class DevToolsWindowDelegate : public views::ClientView,

// views::WidgetDelegate:
views::View* GetInitiallyFocusedView() override { return view_; }
bool CanMaximize() const override { return true; }
bool CanMinimize() const override { return true; }
std::u16string GetWindowTitle() const override { return shell_->GetTitle(); }
ui::ImageModel GetWindowAppIcon() override { return GetWindowIcon(); }
ui::ImageModel GetWindowIcon() override { return icon_; }
Expand Down Expand Up @@ -193,6 +191,7 @@ void InspectableWebContentsViewViews::SetIsDocked(bool docked, bool activate) {

devtools_window_->Init(std::move(params));
devtools_window_->UpdateWindowIcon();
devtools_window_->widget_delegate()->SetHasWindowSizeControls(true);
}

ShowDevTools(activate);
Expand Down