Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(protocols): simplify packaging section & cleanup #30832

Merged
merged 3 commits into from Sep 7, 2021
Merged

docs(protocols): simplify packaging section & cleanup #30832

merged 3 commits into from Sep 7, 2021

Conversation

malept
Copy link
Member

@malept malept commented Sep 3, 2021

Description of Change

Does two things in the protocol guide:

  • Clean up grammar/formatting
  • Replace the packaging section, which references --extend-info (and looks like it came from electron-api-demos) with a more modern set of instructions, as Electron Packager / Electron Forge has a specific parameter or two for macOS protocol support, and Linux support was not addressed.

CC: @electron/wg-ecosystem

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2021
@malept malept changed the title Malept/docs/simplify packager protocol docs(protocols): simplify packaging section & cleanup Sep 3, 2021
@malept malept requested a review from a team September 3, 2021 19:23
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2021
@malept @zcbenz
Fix typo
76bde6d 
Co-authored-by: Cheng Zhao <github@zcbenz.com>
@malept
Copy link
Member Author

malept commented Sep 6, 2021

CI needs to be kicked, appears to be a transient error.

@zcbenz zcbenz merged commit 22abbf7 into electron:main Sep 7, 2021
@trop
Copy link
Contributor

trop bot commented Sep 7, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Sep 7, 2021
@trop
Copy link
Contributor

trop bot commented Sep 7, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

malept added a commit to malept/electron that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup
ba89dcc 
Backport of electron#30194
Backport of electron#30566
Backport of electron#30832
@malept malept deleted the malept/docs/simplify-packager-protocol branch September 8, 2021 04:28
@malept malept mentioned this pull request Sep 8, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 8, 2021

@malept has manually backported this PR to "15-x-y", please check out #30881

malept added a commit to malept/electron that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup
210f8cb 
Backport of electron#30832
@malept malept mentioned this pull request Sep 8, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 8, 2021

@malept has manually backported this PR to "14-x-y", please check out #30882

zcbenz pushed a commit that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup (#30881)
2724456 
Backport of #30194
Backport of #30566
Backport of #30832
zcbenz pushed a commit that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup (#30882)
6f67e50 
Backport of #30832
@commit-lint commit-lint bot mentioned this pull request Nov 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malept @zcbenz @MarshallOfSound