fix: show maximized frameless window

[samuelmaddock]

Description of Change

fixes #30798

Transparent frameless windows do not support being maximized.

We approximate the maximized state by checking if the window takes up the nearest screen's bounds:

electron/shell/browser/native_window_views.cc

Lines 597 to 610 in 49e62f1

	bool NativeWindowViews::IsMaximized() {
	if (widget()->IsMaximized()) {
	return true;
	} else {
	#if defined(OS_WIN)
	if (transparent()) {
	// Compare the size of the window with the size of the display
	auto display = display::Screen::GetScreen()->GetDisplayNearestWindow(
	GetNativeWindow());
	// Maximized if the window is the same dimensions and placement as the
	// display
	return GetBounds() == display.work_area();
	}
	#endif

If that's the case, browserWindow.show() attempts to restore the window to a maximized state which will break its transparency and bounds. See #30798 (comment) for more details.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed transparent frameless windows having an opaque background when opened in a maximized state.

[samuelmaddock]

https://ci.appveyor.com/project/electron-bot/electron-92tg5/builds/40614691?fullLog=true#L45020

not ok 490 BrowserWindow module "transparent" option can show maximized frameless window
  AssertionError: expected { x: 0, y: 0, width: 1024, height: 728 } to deeply equal { x: 0, y: 0, width: 1024, height: 768 }
      at Context.<anonymous> (electron\spec-main\api-browser-window-spec.ts:4671:37)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

Test is failing. Will take another look soon.

oops, accidental 🙃

[codebytere]

Failure

session module ses.setCertificateVerifyProc(callback) saves cached results

is unrelated.

[release-clerk]

Release Notes Persisted

Fixed transparent frameless windows having an opaque background when opened in a maximized state.

[trop]

I have automatically backported this PR to "13-x-y", please check out #30862

[trop]

I have automatically backported this PR to "12-x-y", please check out #30863

[trop]

I have automatically backported this PR to "14-x-y", please check out #30864

[trop]

I have automatically backported this PR to "15-x-y", please check out #30865