Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated webview tag docs to reflect preload behavior with .asar #30768

Merged
merged 1 commit into from Sep 6, 2021
Merged

docs: updated webview tag docs to reflect preload behavior with .asar #30768

merged 1 commit into from Sep 6, 2021

Conversation

iketheguy
Copy link
Contributor

This PR is a documentation update in response to #30656 opened by @Oliver-Fish. It changes the webview tag preload documentation to more accurately reflect the current behavior when referencing asar archives to get the script.

Release Notes

Notes: docs: updated webview tag documentation to accurately reflect preload behavior with asar archives

@welcome
Copy link

welcome bot commented Aug 31, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2021
@iketheguy iketheguy changed the title docs: updated webview tag documentation to accurately reflect preload behavior with asar archives docs: updated webview tag docs to reflect preload behavior with .asar Aug 31, 2021
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Sep 2, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 2, 2021
@codebytere codebytere added new-pr 🌱 PR opened in the last 24 hours target/13-x-y labels Sep 2, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 2, 2021
@zcbenz zcbenz merged commit 4a2f41e into electron:main Sep 6, 2021
@welcome
Copy link

welcome bot commented Sep 6, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 6, 2021

Release Notes Persisted

docs: updated webview tag documentation to accurately reflect preload behavior with asar archives

@trop
Copy link
Contributor

trop bot commented Sep 6, 2021

I have automatically backported this PR to "14-x-y", please check out #30849

@trop trop bot added the in-flight/14-x-y label Sep 6, 2021
@trop
Copy link
Contributor

trop bot commented Sep 6, 2021

I have automatically backported this PR to "13-x-y", please check out #30850

@trop trop bot removed the target/14-x-y label Sep 6, 2021
@trop
Copy link
Contributor

trop bot commented Sep 6, 2021

I have automatically backported this PR to "15-x-y", please check out #30851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants