Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fix for 1234009 from chromium #30752

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 30, 2021

Backport of #30635

See that PR for details.

Notes: Security: Backported fix for 1234009.

@trop trop bot requested a review from a team as a code owner August 30, 2021 10:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2021
@trop trop bot requested a review from zcbenz August 30, 2021 10:35
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2021
@crn2m60m6v50

This comment has been minimized.

Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we actually support the file_system API in extensions?

@zcbenz
Copy link
Member

zcbenz commented Sep 3, 2021

I don't think the file_system API is supported, but the related code is compiled and linked with Electron (though very likely stripped), I'm not sure if we should backport patches in this case 🤔 .

@zcbenz zcbenz closed this Sep 16, 2021
@trop trop bot deleted the trop/12-x-y-bp-chore-cherry-pick-fix-for-1234009-from-chromium-1630319710469 branch September 16, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants