Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove ipc wrapper for nativeImage.createThumbnailFromPath #30728

Merged
merged 2 commits into from Aug 27, 2021
Merged

fix: remove ipc wrapper for nativeImage.createThumbnailFromPath #30728

merged 2 commits into from Aug 27, 2021

Conversation

nornagon
Copy link
Member

Description of Change

This removes the IPC wrapper for nativeImage.createThumbnailFromPath.

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from a team as a code owner August 27, 2021 17:40
@nornagon nornagon added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/minor backwards-compatible functionality target/12-x-y labels Aug 27, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 27, 2021
@nornagon nornagon merged commit aa9da78 into main Aug 27, 2021
@nornagon nornagon deleted the remove-create-thumbnail-from-path-renderer branch August 27, 2021 21:21
@release-clerk
Copy link

release-clerk bot commented Aug 27, 2021

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Aug 27, 2021
Open
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/11-x-y label Aug 27, 2021
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Aug 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

I have automatically backported this PR to "15-x-y", please check out #30734

@nornagon nornagon mentioned this pull request Aug 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

@nornagon has manually backported this PR to "14-x-y", please check out #30735

@nornagon nornagon mentioned this pull request Aug 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

@nornagon has manually backported this PR to "13-x-y", please check out #30736

@nornagon nornagon mentioned this pull request Aug 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

@nornagon has manually backported this PR to "12-x-y", please check out #30737

@nornagon nornagon mentioned this pull request Aug 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2021

@nornagon has manually backported this PR to "11-x-y", please check out #30738

@miniak miniak mentioned this pull request Sep 4, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @MarshallOfSound