feat: deprecate desktopCapturer.getSources in the renderer #30721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
MarshallOfSound
approved these changes
Aug 26, 2021
|
@nornagon shouldn't the whole |
miniak
reviewed
Aug 27, 2021
|
|
||
| ipcMain.handle( | ||
| 'DESKTOP_CAPTURER_GET_SOURCES', | ||
| (event, opts) => desktopCapturer.getSources(opts) |
There was a problem hiding this comment.
this is not going to serialize NativeImage instances
There was a problem hiding this comment.
ah hm, good point... #30729 will fix that.
miniak
approved these changes
Aug 27, 2021
jkleinsc
approved these changes
Sep 2, 2021
|
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Deprecates desktopCapturer.getSources in the renderer. See #30720 for more
details.
Checklist
Release Notes
Notes: Usage of the
desktopCapturer.getSourcesAPI from the renderer process has been deprecated and will be removed.