New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: session.setDisplayMediaRequestHandler #30702
Merged
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c599fc6
feat: session.setMediaRequestHandler
nornagon 72fd6aa
address comments
nornagon 5373a64
iwyu
nornagon fda34cf
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 31c10b6
review, bump typescript-definitions
nornagon d4edceb
fix some stuff
nornagon d474408
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 68f0bef
update for changes to media stream api
nornagon fc36ba4
include patches
nornagon 3b87eb4
chore: update patches
patchup[bot] 8cf7385
Merge branch 'main' into media-request-handler
nornagon 4479e80
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 0ae0dc7
lint
nornagon 36d405c
remove patches applied upstream
nornagon 997a8dc
fix when no media handler installed
nornagon ecdc1ea
add getVideoCaptureDevices so gUM requests can be served
nornagon ba8c9d9
remove PEPPER_ONLY
nornagon 057f4ee
camelCase
nornagon 6dcde55
comments, tests
nornagon 3801884
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 40a6674
new api
nornagon 6ddbad4
lint
nornagon e6173c8
remove log
nornagon a6e8011
simplify request object
nornagon 76834b0
setMediaRequestHandler => setDisplayMediaRequestHandler
nornagon ae328ba
remove unneeded code
nornagon 856f3ae
allow passing WebFrameMain
nornagon 93d2940
Update electron_api_desktop_capturer.cc
nornagon 11e085c
Update electron_api_desktop_capturer.cc
nornagon a501c95
Update shell/browser/electron_browser_context.cc
nornagon 5d2d7e0
review feedback
nornagon a745f3b
throw an error when setting display media request handler to an inval…
nornagon c147347
disable local echo for WebFrameMain audio streams
nornagon 1ba104e
id/name on video streams come from DesktopCapturerSource
nornagon 70ba06d
fix various crash cases and add better errors, improve docs
nornagon aead701
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 5269fba
Merge remote-tracking branch 'origin/main' into media-request-handler
nornagon 716f79a
try skipping when screen source length is 0..?
nornagon f005525
skip screen tests on macOS / x64
nornagon 8c8a464
Update docs/api/session.md
nornagon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these be 'device', 'display', and
null
? The 'AudioCapture' is redundant since the key is 'audioType'.