Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable window controls overlay on macOS (#29253) #30698

Merged
merged 2 commits into from
Sep 16, 2021
Merged

feat: enable window controls overlay on macOS (#29253) #30698

merged 2 commits into from
Sep 16, 2021

Commits on Aug 24, 2021

  1. feat: enable window controls overlay on macOS (#29253) 

    * feat: enable windows control overlay on macOS

* address review feedback

* chore: address review feedback

* Address review feedback

* update doc per review

* only enable WCO when titleBarStyle is overlay

* Revert "only enable WCO when titleBarStyle is overlay"

This reverts commit 1b58b5b.

* Add new titleBarOverlay property to manage feature

* spelling fix

* Update docs/api/frameless-window.md

Co-authored-by: Samuel Attard <sam@electronjs.org>

* Update shell/browser/api/electron_api_browser_window.cc

Co-authored-by: Samuel Attard <sam@electronjs.org>

* update per review feedback

Co-authored-by: Samuel Attard <sam@electronjs.org>
(cherry picked from commit 1f8a46c)
    @jkleinsc
    jkleinsc committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    82fd782 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Merge branch '13-x-y' into backport-macos-overlay

    @jkleinsc
    jkleinsc committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    0ab9687 View commit details
    Browse the repository at this point in the history