fix: titlebar and window buttons under simple fullscreen #30671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Aug 24, 2021
deepak1556
approved these changes
Aug 25, 2021
|
Release Notes Persisted
|
This was referenced Aug 25, 2021
|
I have automatically backported this PR to "13-x-y", please check out #30706 |
|
I have automatically backported this PR to "14-x-y", please check out #30707 |
|
I have automatically backported this PR to "15-x-y", please check out #30708 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
igorgladkoborodov
added a commit
to vv-vim/vv
that referenced
this pull request
Jan 24, 2022
* Upgrade to Electron 16. * Remove the simple fullscreen title bar fix (#105). Looks like it was fixed in electron/electron#30671 * `second-window` event adds Chromium flags to `args` and it breaks the app. Add temporary fix for this just cleaning exact flags. Need to come up with more permanent and reliable fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix 2 problems:
Close #30536.
Release Notes
Notes: Fix titlebar showing under simple fullscreen mode.