Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add <webview> 'did-redirect-navigation' event #30664

Merged
merged 1 commit into from
Sep 2, 2021
Merged

feat: add <webview> 'did-redirect-navigation' event #30664

merged 1 commit into from
Sep 2, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 23, 2021

Backport of #30457

See that PR for details.

Notes: Added <webview> 'did-redirect-navigation' event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2021
@trop trop bot requested a review from miniak August 23, 2021 14:26
@trop trop bot mentioned this pull request Aug 23, 2021
Merged
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Aug 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2021
MarshallOfSound
MarshallOfSound approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases

@jkleinsc jkleinsc merged commit f894f8a into 15-x-y Sep 2, 2021
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-feat-add-webview-did-redirect-navigation-event-1629728775136 branch September 2, 2021 17:25
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2021

Release Notes Persisted

Added &lt;webview&gt; 'did-redirect-navigation' event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
15-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ckerr @MarshallOfSound @jkleinsc @VerteDinde @miniak