fix: crash when using TouchBarScrubber arrow button #30661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
reviewed
Aug 23, 2021
codebytere
force-pushed
the
fix-touch-bar-crash
branch
from
34e9340
to
bbff9c2
Compare
zcbenz
approved these changes
Aug 24, 2021
|
Release Notes Persisted
|
This was referenced Aug 24, 2021
|
I have automatically backported this PR to "14-x-y", please check out #30679 |
|
I have automatically backported this PR to "13-x-y", please check out #30680 |
|
I have automatically backported this PR to "15-x-y", please check out #30681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #30658.
Fixes an issue where the TouchBarScrubber crashes if
itemsis an empty array.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the TouchBarScrubber crashes when
showArrowButtonsis enabled ifitemsis an empty array.