Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain the null webContents case in permission checks #30645

Merged
merged 2 commits into from Aug 25, 2021
Merged

Conversation

MarshallOfSound
Copy link
Member

Closes #30496

Notes: none

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading thru the original issue, this seems clearer to me :)

docs/api/session.md Outdated Show resolved Hide resolved
Co-authored-by: Erick Zhao <erick@hotmail.ca>
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2021
@zcbenz zcbenz merged commit be43996 into main Aug 25, 2021
4 checks passed
@zcbenz zcbenz deleted the wc-null branch August 25, 2021 00:41
@release-clerk
Copy link

release-clerk bot commented Aug 25, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 25, 2021

I have automatically backported this PR to "13-x-y", please check out #30686

@trop
Copy link
Contributor

trop bot commented Aug 25, 2021

I have automatically backported this PR to "14-x-y", please check out #30687

@trop trop bot removed the target/13-x-y label Aug 25, 2021
@trop
Copy link
Contributor

trop bot commented Aug 25, 2021

I have automatically backported this PR to "15-x-y", please check out #30688

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
…n#30645)

* docs: explain the null webContents case in permission checks

* Update docs/api/session.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: permissionCheckHandler webContents is null for main frame permission requests
5 participants