Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fix for 1231950 from v8 #30584

Merged
merged 2 commits into from Aug 18, 2021
Merged

chore: cherry-pick fix for 1231950 from v8 #30584

merged 2 commits into from Aug 18, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 18, 2021

[liftoff][arm64] Zero-extend offsets also for SIMD

This extends https://crrev.com/c/2917612 also for SIMD, which
(sometimes) uses the special {GetMemOpWithImmOffsetZero} method.
As part of this CL, that method is renamed to {GetEffectiveAddress}
which IMO is a better name. Also, it just returns a register to make the
semantic of that function obvious in the signature.

Drive-by: When sign extending to 32 bit, only write to the W portion of
the register. This is a bit cleaner, and I first thought that
this would be the bug.

R=jkummerow@chromium.org
CC=​thibaudm@chromium.org

Bug: chromium:1231950, v8:12018
Change-Id: Ifaefe1f18e3a00534a30c99e3c37ed09d9508f6e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3049073
Reviewed-by: Zhi An Ng zhin@chromium.org
Commit-Queue: Clemens Backes clemensb@chromium.org

[modify] https://crrev.com/b99fe75c6db86d86ad8989458d28978b001d9234/src/wasm/baseline/arm64/liftoff-assembler-arm64.h
[modify] https://crrev.com/b99fe75c6db86d86ad8989458d28978b001d9234/test/mjsunit/mjsunit.status
[add] https://crrev.com/b99fe75c6db86d86ad8989458d28978b001d9234/test/mjsunit/regress/wasm/regress-1231950.js

Notes: Security: Backported fix for 1231950.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/11-x-y labels Aug 18, 2021
@zcbenz zcbenz requested a review from a team as a code owner August 18, 2021 01:00
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
@zcbenz zcbenz added the backport-check-skip Skip trop's backport validity checking label Aug 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
@zcbenz zcbenz changed the title chore: cherry-pick 1231950 from v8 chore: cherry-pick fix for 1231950 from v8 Aug 18, 2021
@zcbenz zcbenz merged commit f2275ec into 13-x-y Aug 18, 2021
@zcbenz zcbenz deleted the cherry-pick-1231950 branch August 18, 2021 23:27
@release-clerk
Copy link

release-clerk bot commented Aug 18, 2021

Release Notes Persisted

Security: Backported fix for 1231950.

@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "11-x-y", please check out #30616

@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "12-x-y", please check out #30617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants