Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: documentEdited with non-default titlebarStyle #30565

Merged
merged 1 commit into from Aug 18, 2021
Merged

fix: documentEdited with non-default titlebarStyle #30565

merged 1 commit into from Aug 18, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #30564.

Fixes an issue where toggling documentEdited status on macOS with titlebarStyle: 'hiddenInset' inadvertently moves the traffic light location. Fix this by ensuring the traffic lights are redrawn according to the current titleBarStyle when documentEdited status is changed.

Tested with https://gist.github.com/166ffcd98c950e6e97fec05ae4f2683b.

Checklist

Release Notes

Notes: Fixed an issue where toggling documentEdited status on macOS with titlebarStyle: 'hiddenInset' inadvertently moves the traffic light location.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Aug 17, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2021
@codebytere codebytere changed the title fix: documentEdited with titlebarStyle: 'hidden' fix: documentEdited with non-default titlebarStyle Aug 17, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
@MarshallOfSound MarshallOfSound merged commit ec13a0b into main Aug 18, 2021
@MarshallOfSound MarshallOfSound deleted the fix-documentedited-traffic-lights branch August 18, 2021 19:09
@release-clerk
Copy link

release-clerk bot commented Aug 18, 2021

Release Notes Persisted

Fixed an issue where toggling documentEdited status on macOS with titlebarStyle: 'hiddenInset' inadvertently moves the traffic light location.

This was referenced Aug 18, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "13-x-y", please check out #30603

@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "15-x-y", please check out #30604

@trop trop bot removed the target/13-x-y label Aug 18, 2021
@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "14-x-y", please check out #30605

miniak pushed a commit that referenced this pull request Aug 18, 2021
@codebytere @miniak
fix: documentEdited with non-default titlebarStyle (#30565)
adcf168
@trop trop bot added the merged/15-x-y label Aug 18, 2021
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@codebytere @BlackHole1
fix: documentEdited with non-default titlebarStyle (electron#30565)
c134e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
3 participants
@codebytere @zcbenz @MarshallOfSound