fix: handle nullish WebContentsView in UpdateDraggableRegions #30556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
the
fast-track 🚅
VerteDinde
approved these changes
Aug 16, 2021
clavin
approved these changes
Aug 16, 2021
zcbenz
approved these changes
Aug 17, 2021
|
Release Notes Persisted
|
This was referenced Aug 17, 2021
|
I have automatically backported this PR to "13-x-y", please check out #30557 |
|
I have automatically backported this PR to "15-x-y", please check out #30558 |
|
I have automatically backported this PR to "14-x-y", please check out #30559 |
miniak
pushed a commit
that referenced
this pull request
Aug 18, 2021
* fix: handle nullish WebContentsView in UpdateDraggableRegions * build: nogncheck on webcontentsimpl include
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
…on#30556) * fix: handle nullish WebContentsView in UpdateDraggableRegions * build: nogncheck on webcontentsimpl include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #30304 the issue was not that the NativeView was missing (it's stack allocated anyway, so truthy checking it didn't do anything). The crash shows a failure in the pointer indirection of the
unique_ptrfor theview. i.e. theviewwas nullptr.Notes: Fixed rare crash in UpdateDraggableRegions