Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wrong code example for preload property #30555

Merged
merged 1 commit into from Sep 7, 2021

Conversation

Paratron
Copy link
Contributor

@Paratron Paratron commented Aug 16, 2021

Description of Change

The docs for the process model mention that preload should be a property of webPreferences, but the code example showed something else.

notes: none

The text mentions that `preload` should be a property of `webPreferences`, but the code example shows something else.
@welcome
Copy link

welcome bot commented Aug 16, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2021
@Paratron Paratron changed the title Fix wrong code example for preload property docs: Fix wrong code example for preload property Aug 16, 2021
@Paratron Paratron changed the title docs: Fix wrong code example for preload property docs: fix wrong code example for preload property Aug 16, 2021
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2021
@codebytere codebytere merged commit ee33374 into electron:main Sep 7, 2021
@welcome
Copy link

welcome bot commented Sep 7, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 7, 2021

No Release Notes

codebytere added a commit that referenced this pull request Sep 7, 2021
@trop
Copy link
Contributor

trop bot commented Sep 7, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Sep 7, 2021
@trop
Copy link
Contributor

trop bot commented Sep 7, 2021

I have automatically backported this PR to "13-x-y", please check out #30872

@trop
Copy link
Contributor

trop bot commented Sep 7, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@erickzhao
Copy link
Member

Removing bp label for 14-x-y because #30800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants