fix: media key globalShortcuts on macOS #30552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
MarshallOfSound
approved these changes
Aug 16, 2021
jkleinsc
requested changes
Aug 16, 2021
codebytere
force-pushed
the
fix-media-keys
branch
from
ec4e610
to
6ad6307
Compare
jkleinsc
approved these changes
Aug 17, 2021
|
Release Notes Persisted
|
This was referenced Aug 17, 2021
|
I have automatically backported this PR to "13-x-y", please check out #30568 |
|
I have automatically backported this PR to "14-x-y", please check out #30569 |
|
I have automatically backported this PR to "15-x-y", please check out #30570 |
miniak
pushed a commit
that referenced
this pull request
Aug 18, 2021
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #30543.
Refs #27475.
This CL moved around the location for media key listener logic in Chromium, and as a result this patch was fully removed instead of being updated (regressing #21959).
This fixes the issue by reinvigorating the patch in accordance with latest upstream logic.
Checklist
npm testpassesRelease Notes
Notes: Fixed media key
globalShortcuts on macOS.