Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable kWindowCaptureMacV2 for desktop capturer #30524

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 13, 2021

Backport of #30507

See that PR for details.

Notes: Fixed an issue on Mac where an application could not capture its own window using the desktop capture or getMediaSourceId APIs.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2021
@trop trop bot requested a review from VerteDinde August 13, 2021 20:24
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 13, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2021
@VerteDinde VerteDinde merged commit fbe3922 into 14-x-y Aug 16, 2021
@VerteDinde VerteDinde deleted the trop/14-x-y-bp-fix-disable-kwindowcapturemacv2-for-desktop-capturer-1628886258113 branch August 16, 2021 18:17
@release-clerk
Copy link

release-clerk bot commented Aug 16, 2021

Release Notes Persisted

Fixed an issue on Mac where an application could not capture its own window using the desktop capture or getMediaSourceId APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant