fix: repl crash when SharedArrayBuffer disabled #30456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
force-pushed
the
fix-shared-array-buffer-crash
branch
from
1eede72
to
51d65a8
Compare
ckerr
reviewed
Aug 9, 2021
There was a problem hiding this comment.
nodejs/node#39718 (review) is a little troubling, if it also applies to Electron.
|
@ckerr it does - i've tuned it up in both places :) |
codebytere
force-pushed
the
fix-shared-array-buffer-crash
branch
from
51d65a8
to
24fbc24
Compare
codebytere
force-pushed
the
fix-shared-array-buffer-crash
branch
from
24fbc24
to
2906740
Compare
ckerr
approved these changes
Aug 10, 2021
zcbenz
approved these changes
Aug 11, 2021
|
Release Notes Persisted
|
This was referenced Aug 11, 2021
|
I have automatically backported this PR to "13-x-y", please check out #30482 |
|
I have automatically backported this PR to "15-x-y", please check out #30483 |
|
I have automatically backported this PR to "14-x-y", please check out #30484 |
miniak
pushed a commit
that referenced
this pull request
Aug 18, 2021
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs nodejs/node#39717.
Can be reproduced with
e node --no-harmony-sharedarraybuffer.Fixes an issue where the repl will crash if it's required in the renderer process or invoked as above.
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash in the repl when
SharedArrayBufferis disabled.