New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for WebHID #30213
Merged
Merged
feat: add support for WebHID #30213
Commits on Sep 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1503f95 - Browse repository at this point
Copy the full SHA 1503f95View commit details -
Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Configuration menu - View commit details
-
Copy full SHA for 2bb376c - Browse repository at this point
Copy the full SHA 2bb376cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb577e - Browse repository at this point
Copy the full SHA fbb577eView commit details
Commits on Sep 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e7f8ccd - Browse repository at this point
Copy the full SHA e7f8ccdView commit details -
chore: clear granted_devices on navigation
Also added test to verify devices get cleared
Configuration menu - View commit details
-
Copy full SHA for a2585e9 - Browse repository at this point
Copy the full SHA a2585e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68cab73 - Browse repository at this point
Copy the full SHA 68cab73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f4b3c - Browse repository at this point
Copy the full SHA 67f4b3cView commit details
Commits on Sep 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bc9cd72 - Browse repository at this point
Copy the full SHA bc9cd72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b9171 - Browse repository at this point
Copy the full SHA 02b9171View commit details
Commits on Sep 16, 2021
-
manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
Configuration menu - View commit details
-
Copy full SHA for 0e90e2e - Browse repository at this point
Copy the full SHA 0e90e2eView commit details -
Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Configuration menu - View commit details
-
Copy full SHA for 66edc75 - Browse repository at this point
Copy the full SHA 66edc75View commit details
Commits on Sep 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 672ee7a - Browse repository at this point
Copy the full SHA 672ee7aView commit details
Commits on Sep 21, 2021
-
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0 The main reason for this was to resolve this crash on Win x64: ok 2 WebContentsView doesn't crash when GCed during allocation Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53) v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400) v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387) node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415) node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479) uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609) electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631) base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266) base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221) base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470) base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136) content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990) content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153) content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49) content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608) content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104) content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971) content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394) content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422) wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291) __scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) BaseThreadInitThunk [0x00007FFEC0087034+20] RtlUserThreadStart [0x00007FFEC1F02651+33] ✗ Electron tests failed with code 0xc0000005.
John Kleinschmidt committedSep 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 668ca2f - Browse repository at this point
Copy the full SHA 668ca2fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.