Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 3feda0244490 from chromium #30196

Merged
merged 1 commit into from Jul 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jul 19, 2021

serial: Fix parent class tracing for SerialPort

When SerialPort was updated to be ActiveScriptWrappable and an
EventTarget the Trace method was not updated to call the parent class
trace methods.

(cherry picked from commit 4059ecc3a5352601a4d79196f90c8ca19262afe1)

Bug: 1220078
Change-Id: If6967a913268bce86d4488359a9418a814530f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965255
Auto-Submit: Reilly Grant reillyg@chromium.org
Commit-Queue: Tom Sepez tsepez@chromium.org
Reviewed-by: Tom Sepez tsepez@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#893039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992740
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Commit-Queue: Reilly Grant reillyg@chromium.org
Cr-Commit-Position: refs/branch-heads/4472@{#1531}
Cr-Branched-From: 3d60439cfb36485e76a1c5bb7f513d3721b20da1-refs/heads/master@{#870763}

Notes: Security: backported fix for CVE-2021-30562.

@ppontes ppontes requested a review from a team as a code owner July 19, 2021 20:14
@ppontes ppontes added 11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Jul 19, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 19, 2021
@ppontes ppontes changed the title chore: cherry-pick 3feda0244490 from chromium [wip] chore: cherry-pick 3feda0244490 from chromium Jul 20, 2021
@ppontes ppontes force-pushed the cherry-pick/11-x-y/chromium/3feda0244490 branch from 6a394d6 to 5376be1 Compare July 21, 2021 10:24
@ppontes ppontes force-pushed the cherry-pick/11-x-y/chromium/3feda0244490 branch from 5376be1 to f8ef370 Compare July 21, 2021 15:39
@ppontes ppontes changed the title [wip] chore: cherry-pick 3feda0244490 from chromium chore: cherry-pick 3feda0244490 from chromium Jul 21, 2021
@ppontes ppontes removed the wip ⚒ label Jul 21, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failures are unrelated to this PR.

@jkleinsc jkleinsc merged commit 73a6dee into 11-x-y Jul 22, 2021
@jkleinsc jkleinsc deleted the cherry-pick/11-x-y/chromium/3feda0244490 branch July 22, 2021 15:13
@release-clerk
Copy link

release-clerk bot commented Jul 22, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-30562.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants