feat: add fuses for NODE_OPTIONS and --inspect #30190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
semver/minor
nornagon
requested changes
Jul 19, 2021
MarshallOfSound
force-pushed
the
inspect-fuse
branch
from
a72e145
to
7a89373
Compare
nornagon
reviewed
Jul 26, 2021
patches/node/add_should_read_node_options_from_env_option_to_disable_node_options.patch
Show resolved
Hide resolved
patches/node/add_should_read_node_options_from_env_option_to_disable_node_options.patch
Outdated
Show resolved
Hide resolved
nornagon
approved these changes
Aug 4, 2021
ckerr
reviewed
Aug 4, 2021
patches/node/add_should_read_node_options_from_env_option_to_disable_node_options.patch
Outdated
Show resolved
Hide resolved
ckerr
approved these changes
Aug 4, 2021
zcbenz
approved these changes
Aug 5, 2021
|
Release Notes Persisted
|
|
I was unable to backport this PR to "14-x-y" cleanly; |
|
I have automatically backported this PR to "15-x-y", please check out #30420 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
* feat: add fuses for NODE_OPTIONS and --inspect * chore: add node patch to ensure NODE_OPTIONS are never parsed when fuse is disabledd * chore: fix lint * chore: flip boolean logic * chore: update patches * chore: add trailing _ to static member * Update add_should_read_node_options_from_env_option_to_disable_node_options.patch * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title / notes. Allows apps to completely opt out of these arguments / env vars in packaged apps.
Notes: Added fuses to disable
NODE_OPTIONSand--inspectdebug arguments in packaged apps