chore: cherry-pick 9bab573a37 from chromium #30084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Jul 12, 2021
|
@deepak1556 this has a handful of CI failures that persist even after I re-run. This patch looks innocent enough though. Are the CI failures unrelated to this PR? |
|
@ckerr CI is broken right now, see #ci. |
ckerr
approved these changes
Jul 12, 2021
|
Failing tests are unrelated, merging. |
|
Release Notes Persisted
|
This was referenced Jul 13, 2021
|
I have automatically backported this PR to "12-x-y", please check out #30099 |
|
I have automatically backported this PR to "13-x-y", please check out #30100 |
|
I have automatically backported this PR to "14-x-y", please check out #30101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3010140
Refs microsoft/vscode#128199
Release Notes
Notes: Backported fix for 1216190