Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable fullscreen test on mac arm #30083

Merged
merged 1 commit into from Jul 12, 2021

Conversation

deepak1556
Copy link
Member

Description of Change

#30081 attempted to reduce the flakiness of the test but it still fails in CI https://github.com/electron/electron/runs/3043847085, I am unable to repro the failure locally hence disabling it.

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 12, 2021
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@deepak1556
Copy link
Member Author

Failing test are unrelated, merging.

@deepak1556 deepak1556 merged commit 36079b8 into main Jul 12, 2021
@deepak1556 deepak1556 deleted the robo/disable_flaky_fullscreen_mac_arm64 branch July 12, 2021 15:53
@release-clerk
Copy link

release-clerk bot commented Jul 12, 2021

No Release Notes

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours no-backport semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants