Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update quick-start.md #30064

Merged
merged 1 commit into from Jul 14, 2021
Merged

docs: update quick-start.md #30064

merged 1 commit into from Jul 14, 2021

Conversation

Davenury
Copy link
Contributor

@Davenury Davenury commented Jul 9, 2021

Change app-quit link definition, so both window-all-closed and app-quit redirects to appropriate sites.

Description of Change

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

Change app-quit link definition, so both window-all-closed and app-quit redirects to appropriate sites.
@welcome
Copy link

welcome bot commented Jul 9, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 9, 2021
@Davenury Davenury changed the title Update quick-start.md docs: update quick-start.md Jul 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
@zcbenz zcbenz merged commit 75b4267 into electron:main Jul 14, 2021
4 checks passed
@welcome
Copy link

welcome bot commented Jul 14, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jul 14, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "12-x-y", please check out #30132

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "13-x-y", please check out #30133

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "14-x-y", please check out #30134

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
Change app-quit link definition, so both window-all-closed and app-quit redirects to appropriate sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants