Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return RGBA values from getSystemColor #30055

Merged
merged 1 commit into from Jul 12, 2021
Merged

fix: return RGBA values from getSystemColor #30055

merged 1 commit into from Jul 12, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jul 8, 2021

Description of Change

Fixes #26628.

The docs already state that this returns #RRGGBBAA, so this change brings the
function in line with the docs.

Checklist

Release Notes

Notes: Fixed systemPreferences.getSystemColor returning colors missing alpha values.

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/13-x-y labels Jul 8, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 8, 2021
zcbenz
zcbenz approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only 2 pieces of code using this API I found on GitHub all assume RGBA value, so I guess this change should be fine.

@nornagon
Copy link
Member Author

tests are flake; merging.

@nornagon nornagon merged commit 0cb5631 into main Jul 12, 2021
@nornagon nornagon deleted the system-color-rgba branch July 12, 2021 18:08
@release-clerk
Copy link

release-clerk bot commented Jul 12, 2021

Release Notes Persisted

Fixed systemPreferences.getSystemColor returning colors missing alpha values.

This was referenced Jul 12, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 12, 2021

I have automatically backported this PR to "14-x-y", please check out #30087

@trop
Copy link
Contributor

trop bot commented Jul 12, 2021

I have automatically backported this PR to "13-x-y", please check out #30088

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@nornagon @BlackHole1
fix: return RGBA values from getSystemColor (electron#30055)
c946e76
@jcarpenter jcarpenter mentioned this pull request Mar 31, 2022
Closed
3 tasks
@zcbenz zcbenz mentioned this pull request Jul 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support alpha values in systemPreferences.getColor()
2 participants
@nornagon @zcbenz