Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable window controls overlay on macOS #29986

Merged
merged 12 commits into from Jul 8, 2021
Merged

feat: enable window controls overlay on macOS #29986

merged 12 commits into from Jul 8, 2021

Commits on Jul 1, 2021

  1. feat: enable windows control overlay on macOS

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    6d8e5a7 View commit details
    Browse the repository at this point in the history

  2. address review feedback

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    c361651 View commit details
    Browse the repository at this point in the history

  3. chore: address review feedback

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    147845c View commit details
    Browse the repository at this point in the history

  4. Address review feedback

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    51a7df7 View commit details
    Browse the repository at this point in the history

  5. update doc per review

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    a594578 View commit details
    Browse the repository at this point in the history

  6. only enable WCO when titleBarStyle is overlay

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    d26a130 View commit details
    Browse the repository at this point in the history

  7. Revert "only enable WCO when titleBarStyle is overlay" 

    This reverts commit 1b58b5b.
    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    8b27f55 View commit details
    Browse the repository at this point in the history

  8. Add new titleBarOverlay property to manage feature

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    8e487aa View commit details
    Browse the repository at this point in the history

  9. spelling fix

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    b8c52a4 View commit details
    Browse the repository at this point in the history

  10. Update docs/api/frameless-window.md 

    Co-authored-by: Samuel Attard <sam@electronjs.org>
    @jkleinsc @MarshallOfSound @electron-bot
    2 people authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    7f5c114 View commit details
    Browse the repository at this point in the history

  11. Update shell/browser/api/electron_api_browser_window.cc 

    Co-authored-by: Samuel Attard <sam@electronjs.org>
    @jkleinsc @MarshallOfSound @electron-bot
    2 people authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    0185768 View commit details
    Browse the repository at this point in the history

  12. update per review feedback

    @jkleinsc @electron-bot
    jkleinsc authored and electron-bot committed Jul 1, 2021
    Copy the full SHA
    d4c67f5 View commit details
    Browse the repository at this point in the history