fix: self.module.paths not working in web workers #29955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
changed the title
jkleinsc
requested changes
Jun 30, 2021
codebytere
force-pushed
the
fix-self-module-paths
branch
from
bb57b27
to
2bd8d54
Compare
jkleinsc
approved these changes
Jun 30, 2021
nornagon
approved these changes
Jun 30, 2021
zcbenz
approved these changes
Jul 4, 2021
|
Release Notes Persisted
|
This was referenced Jul 4, 2021
|
I have automatically backported this PR to "12-x-y", please check out #30012 |
|
I have automatically backported this PR to "13-x-y", please check out #30013 |
|
I have automatically backported this PR to "14-x-y", please check out #30014 |
|
Thanks to you three. 🙂 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
* fix: global.module.paths in workers * spec: add a regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #24735.
Fixes an issue where
self.module.pathsdidn't work in a web worker context. Fixed with the same logic as is present inrenderer/init.ts.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
self.module.pathswouldn't work in Workers.