fix: correctly propagate title updates for window with no navigation entries #29946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ya, working on it. |
MarshallOfSound
approved these changes
Jun 30, 2021
codebytere
approved these changes
Jun 30, 2021
|
Release Notes Persisted
|
This was referenced Jun 30, 2021
|
I have automatically backported this PR to "13-x-y", please check out #29958 |
|
I have automatically backported this PR to "14-x-y", please check out #29959 |
|
I have automatically backported this PR to "12-x-y", please check out #29960 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #29942.
Sometimes pages don't have any navigation entries associated with them, e.g.
when calling
window.open(''). This allows the page title update to bepropagated even in that instance.
I suspect this method could be even further simplified, but this is the minimal
change to fix the linked bug.
Checklist
npm testpassesRelease Notes
Notes: Fixed page title not being updated on child windows without navigation entries under nativeWindowOpen.