feat: add missing resourceType conversions for webRequest listener details #29902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
added
no-backport
semver/patch
miniak
force-pushed
the
miniak/web-request-resource-types
branch
from
1433c66
to
6b32a10
Compare
codebytere
approved these changes
Jun 28, 2021
nornagon
approved these changes
Jul 7, 2021
deepak1556
approved these changes
Jul 8, 2021
|
Release Notes Persisted
|
|
I have automatically backported this PR to "14-x-y", please check out #30050 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
remusao
added a commit
to ghostery/adblocker
that referenced
this pull request
Sep 22, 2021
remusao
added a commit
to ghostery/adblocker
that referenced
this pull request
Sep 22, 2021
remusao
added a commit
to ghostery/adblocker
that referenced
this pull request
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Making it match enum class WebRequestResourceType in Chromium. Also add strong typing for the enum values in TypeScript.
Note: I am not sure if this is considered a semver/patch as values previously returned as
otherare now converted to the appropriate value name.Checklist
npm testpassesRelease Notes
Notes: Added missing
resourceTypeconversions forwebRequestlistener details:font,ping,cspReport,media,webSocket.