Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add <webview> 'did-attach' event documentation #29899

Merged
merged 1 commit into from Jul 14, 2021
Merged

docs: add <webview> 'did-attach' event documentation #29899

merged 1 commit into from Jul 14, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 25, 2021 •
edited

Description of Change

Fix #10042. Document an existing event

electron/lib/common/web-view-events.ts

Line 3 in 2131992

'did-attach': [],

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added

Release Notes

Notes: none

@miniak miniak self-assigned this Jun 25, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2021
@miniak miniak added target/12-x-y semver/patch backwards-compatible bug fixes labels Jun 25, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2021
@nornagon nornagon added semver/none semver/patch backwards-compatible bug fixes and removed semver/patch backwards-compatible bug fixes semver/none labels Jun 28, 2021
@nornagon
Copy link
Member

eh i guess this affects the typings, so semver/patch.

@zcbenz zcbenz merged commit c0995b8 into main Jul 14, 2021
4 checks passed
@zcbenz zcbenz deleted the miniak/webview-did-attach-event branch July 14, 2021 11:59
@release-clerk
Copy link

release-clerk bot commented Jul 14, 2021

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Jul 14, 2021
Merged
This was referenced Jul 14, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "13-x-y", please check out #30129

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "12-x-y", please check out #30130

@trop trop bot removed the target/12-x-y label Jul 14, 2021
@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "14-x-y", please check out #30131

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@miniak @BlackHole1
docs: add <webview> 'did-attach' event documentation (electron#29899)
b9652ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

@miniak miniak

Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document webview did-attach event
4 participants
@miniak @nornagon @zcbenz @dsanders11