fix: Inspector method overrides when contextIsolation enabled #29841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-inspector-overrides
branch
from
cbb0552
to
6c2fd7d
Compare
codebytere
force-pushed
the
fix-inspector-overrides
branch
from
6c2fd7d
to
110d033
Compare
codebytere
force-pushed
the
fix-inspector-overrides
branch
from
110d033
to
e84b922
Compare
deepak1556
approved these changes
Jun 22, 2021
MarshallOfSound
approved these changes
Jun 22, 2021
nornagon
reviewed
Jun 22, 2021
nornagon
approved these changes
Jun 22, 2021
|
Failure not germane - merging. |
|
Release Notes Persisted
|
This was referenced Jun 24, 2021
|
I have automatically backported this PR to "13-x-y", please check out #29885 |
|
I have automatically backported this PR to "14-x-y", please check out #29886 |
3 tasks
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #29543.
Introduced with the default change from
contextIsolation: falsetocontextIsolation: true. WhencontextIsolationis enabled,window.InspectorFrontendHost,window.Persistence, andwindow.UIare all undefined in the isolated world. We therefore need to set them with thecontextBridgeso that we can override them correctly.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where dropdown menus did not work in DevTools when
contextIsolationwas enabled.