chore: cherry-pick b77b38a3380c from chromium #29823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
added
11-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
nornagon
approved these changes
Jun 21, 2021
zcbenz
approved these changes
Jun 23, 2021
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that XRLayer includes base EventTarget in Trace
Trace was skipping a level in the class hierarchy and calling
ScriptWrappable::Trace() instead. This was likely the result of the
class inheritance changing in the spec a while back and getting updated
elsewhere but not here, since it didn't raise any warnings.
(cherry picked from commit 01b6f7e0a70648d7c7302454993f0bf86d5a0241)
Bug: 1219857
Change-Id: I4ac9f7b037ac5e5dd0e6d670f1d5a30e6344862f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2964533
Commit-Queue: Brandon Jones bajones@chromium.org
Reviewed-by: Alexander Cooper alcooper@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#892650}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967199
Auto-Submit: Brandon Jones bajones@chromium.org
Commit-Queue: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Cr-Commit-Position: refs/branch-heads/4472@{#1492}
Cr-Branched-From: 3d60439cfb36485e76a1c5bb7f513d3721b20da1-refs/heads/master@{#870763}
Notes: Security: backported fix for CVE-2021-30554.