Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fd8cbdf7b888 from v8 #29815

Merged
merged 2 commits into from Jun 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jun 21, 2021

[M86-LTS] Reland "Merged: [compiler] Always record constness dependency for FastDataConstant"

This is a reland of 638d1b238d510a349bdd38648add8d5c85bc5f7d after a
one-character change. A local variable still has a non-optional type
in this version of V8.

Original change's description:

Merged: [compiler] Always record constness dependency for FastDataConstant

Revision: 1bfa5139966fe0c9e8036fe6362b61c483675775

BUG=chromium:1209558
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If4f7243647bcc12ed482796c1353f0717630f6b9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919823
Commit-Queue: Georg Neis neis@chromium.org
Reviewed-by: Igor Sheludko ishell@chromium.org
Cr-Commit-Position: refs/branch-heads/9.1@{#59}
Cr-Branched-From: 0e4ac64a8cf298b14034a22f9fe7b085d2cb238d-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72d5ba88daae35a59d0f978643e2343e912-refs/heads/master@{#73847}

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

(cherry picked from commit 73666e3f6d6bdbc93ab81cf8b3803dd04930e293)

Bug: chromium:1209558
Change-Id: I0c81353882b0f17942fd92ad4181732f941bcb1d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939991
Commit-Queue: Georg Neis neis@chromium.org
Reviewed-by: Igor Sheludko ishell@chromium.org
Cr-Original-Commit-Position: refs/branch-heads/9.1@{#63}
Cr-Original-Branched-From: 0e4ac64a8cf298b14034a22f9fe7b085d2cb238d-refs/heads/9.1.269@{#1}
Cr-Original-Branched-From: f565e72d5ba88daae35a59d0f978643e2343e912-refs/heads/master@{#73847}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2948652
Reviewed-by: Artem Sumaneev asumaneev@google.com
Commit-Queue: Victor-Gabriel Savu vsavu@google.com
Cr-Commit-Position: refs/branch-heads/8.6@{#108}
Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Notes: Security: backported fix for chromium:1209558.

@ppontes ppontes requested a review from a team as a code owner June 21, 2021 11:27
@ppontes ppontes added 11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Jun 21, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jun 21, 2021
@zcbenz zcbenz merged commit a6f3f2f into 11-x-y Jun 22, 2021
@zcbenz zcbenz deleted the cherry-pick/11-x-y/v8/fd8cbdf7b888 branch June 22, 2021 06:08
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2021

Release Notes Persisted

Security: backported fix for chromium:1209558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants