Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: child window alwaysOnTop level persistence #29813

Merged
merged 4 commits into from Jun 23, 2021
Merged

fix: child window alwaysOnTop level persistence #29813

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44cbc42
fix: child window alwaysOnTop level
codebytere Jun 21, 2021
bf37970
chore: add undocumented getAlwaysOnTopLevel
codebytere Jun 22, 2021
fd6b251
test: add test for level persistence
codebytere Jun 22, 2021
4cc5d30
Address feedback from review
codebytere Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion shell/browser/native_window_mac.mm
View file
Open in desktop
Expand Up @@ -1805,10 +1805,15 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {

// Set new parent window.
// Note that this method will force the window to become visible.
if (parent && attach)
if (parent && attach) {
// Attaching a window as a child window resets its window level, so
// save and restore it afterwards.
NSInteger level = window_.level;
[parent->GetNativeWindow().GetNativeNSWindow()
addChildWindow:window_
ordered:NSWindowAbove];
[window_ setLevel:level];
}
}

void NativeWindowMac::SetForwardMouseMessages(bool forward) {
Expand Down