Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable windows control overlay on Windows #29600
feat: enable windows control overlay on Windows #29600
Changes from 33 commits
9e9f507
2e73bad
c578ce4
2f223d2
70eee04
053ee16
6ee51e6
ab0ad2f
4c0a117
be293b5
7fe47bc
c82d86d
94674d4
83eba0f
76965a1
7655b9a
2eda4bf
556e53f
d5b5866
126d976
4703f62
0ab75b2
10dc4d8
4e5b292
63b581c
c464510
0f29067
1bfb8bb
1fcca6d
91a3c5d
5713c20
6827045
75da694
4864bb3
5757e00
1f1a51d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
is vs. specifying an object. Maybe something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, specifying true will result in default colors being used, similarly to not specifying an option like mentioned here. Since the concept of "default colors" only applies to Windows with no customization in macOS, maybe:
And maybe also modifying that description in frameless-window.md so that the same information is in both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated both of these descriptions in the most recent commit. Are they more clear now?