Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modernize protocol-handler docs #29380

Merged
merged 6 commits into from Jul 8, 2021
Merged

docs: modernize protocol-handler docs #29380

merged 6 commits into from Jul 8, 2021

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented May 27, 2021 •
edited

Description of Change

Changed docs to use protocol.registerFileProtocol rather than app.setAsDefaultProtocol and removed legacy code from the index.html file.

Checklist

Release Notes

Notes: update protocol-handler docs to use protocol.registerFileProtocol

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2021
@VerteDinde VerteDinde merged commit b716442 into electron:main Jul 8, 2021
@release-clerk
Copy link

release-clerk bot commented Jul 8, 2021

Release Notes Persisted

update protocol-handler docs to use protocol.registerFileProtocol

This was referenced Jul 8, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 8, 2021

I have automatically backported this PR to "12-x-y", please check out #30056

@trop
Copy link
Contributor

trop bot commented Jul 8, 2021

I have automatically backported this PR to "13-x-y", please check out #30057

@trop
Copy link
Contributor

trop bot commented Jul 8, 2021

I have automatically backported this PR to "14-x-y", please check out #30058

@georgexu99 georgexu99 deleted the george/protocolDocs branch July 8, 2021 23:08
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@georgexu99 @BlackHole1
docs: modernize protocol-handler docs (electron#29380)
7627786 
* docs: modernize protocol-handler docs

* docs: iadd contextIsolation

* docs: add guide for launch-app-from-URL-in-other-app

* docs: address comments

* chore: fix brackets

* chore: add escaped brackets
@ryantheleach
Copy link

ryantheleach commented Mar 3, 2022 •
edited

I looked into the history of this file, after running into issues with the example.

This PR's description / commit doesn't match the changes performed....

b716442

"Changed docs to use protocol.registerFileProtocol rather than app.setAsDefaultProtocol and removed legacy code from the index.html file."

The final copy, as committed when squashed, does not reference protocol.registerFileProtocol at all.

Frankly as someone who has volunteered time and effort to open source in the past, this confuses me greatly that this has happened, and as a new user to electron it's not been very smooth despite the seemingly abundant docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon left review comments

@erickzhao erickzhao erickzhao left review comments

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@georgexu99 @ryantheleach @nornagon @VerteDinde @erickzhao @zcbenz