Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust initial webContents focus calculation #29204

Merged
merged 4 commits into from May 19, 2021
Merged

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented May 18, 2021

Description of Change

Fixes #28897

Also verified to not regress #25287

Checklist

Release Notes

Notes: fix incorrect value of document.focus when opening multiple windows on macOS

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 18, 2021
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/12-x-y wip ⚒ labels May 18, 2021
@deepak1556
Copy link
Member Author

Marking wip to add some tests.

@deepak1556
Copy link
Member Author

woa failures are not related, merging.

@deepak1556 deepak1556 merged commit 77297f3 into master May 19, 2021
@release-clerk
Copy link

release-clerk bot commented May 19, 2021

Release Notes Persisted

fix incorrect value of document.focus when opening multiple windows on macOS

@deepak1556 deepak1556 deleted the remove-focus branch May 19, 2021 09:27
@trop
Copy link
Contributor

trop bot commented May 19, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 19, 2021

I have automatically backported this PR to "13-x-y", please check out #29234

deepak1556 added a commit that referenced this pull request May 19, 2021
* fix: adjust initial webContents focus calculation

* fix: active window check on mac

* fix: about:blank focus behavior

* chore: add spec

Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
@trop
Copy link
Contributor

trop bot commented May 19, 2021

@deepak1556 has manually backported this PR to "12-x-y", please check out #29235

deepak1556 added a commit that referenced this pull request May 19, 2021
* fix: adjust initial webContents focus calculation

* fix: active window check on mac

* fix: about:blank focus behavior

* chore: add spec

Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>

Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 19, 2021
@deepak1556 deepak1556 mentioned this pull request Jun 23, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: document.hasFocus() returns true for all windows opened on startup
4 participants