fix: aspect ratio when max width/height is set

[CezaryKulakowski]

Add the native frame border size to the minimum and maximum size if
the view reports its size as the client size. It allows to enlarge
window to proper values when aspect ratio and max width/height are
set. It also fixes DCHECK which was triggered when user tried to
enlarge window above dimensions set during creation of the
BrowserWindow.

Fixes #29100

Description of Change

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fixed respecting aspect ratio when maximum size is set on BrowserWindow

[zcbenz]

I think the patch itself is good, can you also try to upstream this patch to Chromium?

This PR requires review from @electron/wg-upgrades.

[CezaryKulakowski]

I'll try.

[nornagon]

Patch is pretty small and self-contained, but there are no tests. We periodically sweep our patch list and remove patches that don't cause tests to fail when deleted, so this would be liable to be removed without a test.

[CezaryKulakowski]

@nornagon it would be hard (if possible) to create test for it as current testing environment does't allow to perform user initiated window resize (i.e. resize with mouse and window's edge). It would require browser test functionality and generating winapi events WM_SIZING.

[CezaryKulakowski]

I was trying to get a repro on clean chromium to be able to upstream the fix to them. Unfortunately the only use case in chromium which uses this code (at least the only one I was able to find) is html5 video's pip: https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/requestPictureInPicture. The problem is that this window is frameless so its content size is equal to its window size and check which I added is not needed for such case (it also wouldn't break anything but we won't be able to get a repro).

[CezaryKulakowski]

I've just checked that I should be able to create spec test for it. I'll handle it tomorrow and I'all also rebase the changes to the newest main.

[CezaryKulakowski]

I've pushed branch rebased to the newest main. I've also added a test.

[zcbenz]

Test has been added and I think this PR should be ready to go, we still need approval from @electron/wg-upgrades.

[deepak1556]

LGTM since it now addresses #29101 (review)

Tests have been added

[release-clerk]

Release Notes Persisted

fixed respecting aspect ratio when maximum size is set on BrowserWindow

[trop]

I have automatically backported this PR to "14-x-y", please check out #31955

[trop]

I have automatically backported this PR to "15-x-y", please check out #31956

[trop]

I have automatically backported this PR to "16-x-y", please check out #31957

[trop]

I have automatically backported this PR to "17-x-y", please check out #31958