Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <webview> focus / blur events don't work with contextIsolation enabled #29026

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: <webview> focus / blur events don't work with contextIsolation enabled #29026

merged 1 commit into from
May 7, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 5, 2021

Backport of #29004

See that PR for details.

Notes: Fixed <webview> focus / blur events not working with contextIsolation enabled.

@trop trop bot mentioned this pull request May 5, 2021
Merged
4 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 5, 2021
@trop trop bot added 10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 5, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2021
zcbenz
zcbenz requested changes May 6, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing

[tsl] ERROR in /home/builduser/project/src/electron/lib/renderer/web-view/web-view-impl.ts(161,22)
      TS2531: Object is possibly 'null'.

@miniak miniak force-pushed the miniak/webview-focus-ctx-isolation-10-x-y branch from c1a5874 to d990be3 Compare May 6, 2021 17:02
@miniak miniak requested a review from zcbenz May 6, 2021 19:12
@miniak
Copy link
Contributor Author

miniak commented May 7, 2021

@zcbenz it's interesting that PRs targeting other branches didn't hit this issue. Fixed now

@zcbenz zcbenz merged commit 29d8cf5 into 10-x-y May 7, 2021
@release-clerk
Copy link

release-clerk bot commented May 7, 2021

Release Notes Persisted

Fixed &lt;webview&gt; focus / blur events not working with contextIsolation enabled.

@zcbenz zcbenz deleted the miniak/webview-focus-ctx-isolation-10-x-y branch May 7, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @zcbenz