Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick e4abe032f3ad from chromium #28806

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 23, 2021

Ensure that BrowserContext is not used after it has been freed

Previously, it was possible for the BrowserContext to be destroyed
before ReportAnchorElementMetricsOnClick attempted to access it.

The fix uses the fact that NavigationPredictor extends
WebContentsObserver and checks that web_contents is still alive
before dereferencing BrowserContext. WebContents will always
outlive BrowserContext.

R=​​lukasza@chromium.org, ryansturm@chromium.org

(cherry picked from commit 7313a810ae0b1361cbe8453bc5496654dee24c76)

(cherry picked from commit f782a440339fa19a44422ca5e7165cddd1cffcc9)

Bug: 1197904
Change-Id: Iee4f126e92670a84d57c7a4ec7d6f702fb975c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821639
Reviewed-by: Ryan Sturm ryansturm@chromium.org
Reviewed-by: Łukasz Anforowicz lukasza@chromium.org
Commit-Queue: Łukasz Anforowicz lukasza@chromium.org
Cr-Original-Original-Commit-Position: refs/heads/master@{#872021}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827043
Auto-Submit: Robert Ogden robertogden@chromium.org
Commit-Queue: Ryan Sturm ryansturm@chromium.org
Cr-Original-Commit-Position: refs/branch-heads/4472@{#77}
Cr-Original-Branched-From: 3d60439cfb36485e76a1c5bb7f513d3721b20da1-refs/heads/master@{#870763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830308
Reviewed-by: Tarun Bansal tbansal@chromium.org
Commit-Queue: Tarun Bansal tbansal@chromium.org
Commit-Queue: Robert Ogden robertogden@chromium.org
Cr-Commit-Position: refs/branch-heads/4430@{#1297}
Cr-Branched-From: e5ce7dc4f7518237b3d9bb93cccca35d25216cbe-refs/heads/master@{#857950}

Notes: Security: backported fix for CVE-2021-21226.

@ppontes ppontes requested a review from a team as a code owner April 23, 2021 19:09
@ppontes ppontes added 12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Apr 23, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 23, 2021
@zcbenz zcbenz merged commit 2ebd4ea into 12-x-y Apr 26, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 26, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-21226.

@zcbenz zcbenz deleted the cherry-pick/12-x-y/chromium/e4abe032f3ad branch April 26, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants