feat: add session.storagePath to get path on disk for session data #28665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/13-x-y
semver/minor
jkleinsc
approved these changes
Apr 15, 2021
nornagon
approved these changes
Apr 27, 2021
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
|
I have automatically backported this PR to "13-x-y", please check out #28866 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For apps that have multiple sessions that have their own settings / config storage it is sometimes a requirement to store those settings / config options per-session. Currently the paths to these sessions are predictable but not guaranteed, this use case is made way safer by just exposing this path.
Notes: Added new
session.storagePathAPI to get the path on disk for session-specific data