feat: add BrowserWindow.isFocusable() #28642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
codebytere
force-pushed
the
is-focusable
branch
from
1aa5655
to
33806e3
Compare
MarshallOfSound
approved these changes
Apr 13, 2021
miniak
approved these changes
Apr 13, 2021
jkleinsc
approved these changes
Apr 14, 2021
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #28623.
Adds the corresponding
isFocusablemethod to existingBrowserWindow.setFocusable(). As noted in the issue, there are myriad use cases where one would want to know the value of a window's focusability without needing to manually keep track of various calls tosetFocusable.Checklist
npm testpassesRelease Notes
Notes: Added
BrowserWindow.isFocusable()to determine whether a window is focusable.