feat: expose des-ede3 cipher #27992

trop · 2021-03-04T00:20:34Z

Backport of #27897

See that PR for details.

Notes: Added support for the des-ede3 cipher in node crypto.

jkleinsc · 2021-03-04T20:52:42Z

Merging as CI failures are known flakes unrelated to this PR.

release-clerk · 2021-03-04T20:52:48Z

Release Notes Persisted

Added support for the des-ede3 cipher in node crypto.

ChALkeR · 2021-03-10T22:03:30Z

This is labeled semver/minor but ended up in 12.0.1?
Wasn't this supposed to be 12.1.0, or am I missing something?

nornagon · 2021-03-22T17:21:39Z

This is labeled semver/minor but ended up in 12.0.1?
Wasn't this supposed to be 12.1.0, or am I missing something?

12.0.1 was mislabelled due to an internal tooling error and should have been 12.1.0. We've fixed the issue so it shouldn't happen again :)

ChALkeR · 2021-03-22T17:36:55Z

Thanks! 🎉

feat: expose des-ede3 cipher

a3e8beb

trop bot requested a review from a team as a code owner March 4, 2021 00:20

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 4, 2021

trop bot requested a review from nornagon March 4, 2021 00:20

trop bot mentioned this pull request Mar 4, 2021

feat: expose des-ede3 cipher #27897

Merged

2 tasks

trop bot added 12-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Mar 4, 2021

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 4, 2021

nornagon approved these changes Mar 4, 2021

View reviewed changes

jkleinsc approved these changes Mar 4, 2021

View reviewed changes

jkleinsc merged commit 189f7e0 into 12-x-y Mar 4, 2021

trop bot deleted the trop/12-x-y-bp-feat-expose-des-ede3-cipher-1614817224701 branch March 4, 2021 20:52

Provide feedback