Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement allowFileAccess loadExtension option #27703

Merged
merged 3 commits into from
Feb 16, 2021
Merged

feat: implement allowFileAccess loadExtension option #27703

merged 3 commits into from
Feb 16, 2021

Conversation

nornagon
Copy link
Member

Backport of #25198.

Notes: Added allowFileAccess option to loadExtension() API.

@ChALkeR @samuelmaddock @nornagon
feat: implement allowFileAccess loadExtension option (#25198)
659aaf2 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@nornagon nornagon added the semver/minor backwards-compatible functionality label Feb 11, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Feb 11, 2021
@trop trop bot mentioned this pull request Feb 11, 2021
Merged
7 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2021
@m4heshd
Copy link

m4heshd commented Feb 11, 2021

Impatiently waiting for this to be in the stable release.

@codebytere codebytere removed the backport This is a backport PR label Feb 11, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2021
@codebytere codebytere added backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 11, 2021
@codebytere codebytere mentioned this pull request Feb 11, 2021
Closed
@codebytere
Copy link
Member

Lint is dying on

> electron@11.2.3 lint:docs-relative-links /home/builduser/project/src/electron
> python ./script/check-relative-doc-links.py

File Location: /home/builduser/project/src/electron/docs/api/browser-window.md
	Broken links: session.md#sesloadextensionpath
	Broken links: session.md#sesloadextensionpath

@codebytere codebytere removed the backport This is a backport PR label Feb 11, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed api-review/requested 🗳 labels Feb 11, 2021
@codebytere codebytere added api-review/requested 🗳 backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 11, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Feb 11, 2021
@codebytere codebytere removed the backport This is a backport PR label Feb 11, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2021
@codebytere codebytere added backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 11, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2021
@codebytere codebytere changed the title feat: implement allowFileAccess loadExtension option (#25198) feat: implement allowFileAccess loadExtension option Feb 12, 2021
@nornagon nornagon merged commit 5b81463 into 11-x-y Feb 16, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 16, 2021

Release Notes Persisted

Added allowFileAccess option to loadExtension() API.

@nornagon nornagon deleted the backport/11-x-y/extension-file-access branch February 16, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
11-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @m4heshd @codebytere @ChALkeR