Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in crypto.createDiffieHellman #27700

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 10, 2021

Backport of #27674

See that PR for details.

Notes: Fixed a crash when calling crypto.createDiffieHellman() with certain parameters.

@trop trop bot requested a review from a team as a code owner February 10, 2021 22:11
@trop trop bot requested a review from codebytere February 10, 2021 22:11
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2021
@trop trop bot mentioned this pull request Feb 10, 2021
4 tasks
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 10, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failures are unrelated to PR change.

@jkleinsc jkleinsc merged commit 962f1aa into 12-x-y Feb 11, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 11, 2021

Release Notes Persisted

Fixed a crash when calling crypto.createDiffieHellman() with certain parameters.

@trop trop bot deleted the trop/12-x-y-bp-fix-crash-in-crypto-creatediffiehellman-1612995063589 branch February 11, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants